-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Ransack to be tested with Rails main branch #1192
Conversation
Let me take a look at |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm cool with this and I agree with you that it'd be nice to discover breakage as soon as it happens 👍.
What I dislike is the fact of checking this for every PR, because I like PRs to be green for merging them, and doing this makes a PR potentially red at any time, without it being caused by the changes in a PR. My personal practice is that a PR should be green if and only if the changes in the PR are good.
What I like to do is using a daily scheduled worklfow for this. Currently github doesn't support builtin notifications for this, so if you want notifications you need to do a bit more work, but just having it run daily and being able to check the status in the actions tab helps I believe.
Thanks for the review and I understand what you do not like. Let me create another workflow called "cronjob" or something like that which executes daily cron job against Rails master branch. |
There was a similar change made for Rails 6.1 via #1035
Are you happy for this to be merged now @deivid-rodriguez ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
This pull request allows Ransack to be tested with Rails master branch aka 6.2.0.alpha.
Let me explain some background for this change.
Ransack (polyamorous) depends on some Rails internal APIs and Rails internal APIs change without deprecation warnings. In the long term, Ransack (polyamorous) may not depend on these internal API, but as of now, what we can do is run CI against Rails master branch so that we will able to know which commits 'break' Ransack behavior.