Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #1233

Merged
merged 1 commit into from
Jun 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
ignored when block parameter is specified.
PR [#818](https://github.com/activerecord-hackery/ransack/pull/818).

* No need pass some arugments to JoinAssociation#join_constraints in Rails 5.1.
* No need pass some arguments to JoinAssociation#join_constraints in Rails 5.1.
PR [#814](https://github.com/activerecord-hackery/ransack/pull/814).
Fixes [#807](https://github.com/activerecord-hackery/ransack/issues/807).
Reference [rails/rails#28267](https://github.com/rails/rails/pull/28267)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ See this feature: https://www.postgresql.org/docs/13/queries-order.html

#### Case Insensitive Sorting in PostgreSQL

In order to request PostgresSQL to do a case insensitive sort for all string columns of a model at once, Ransack can be extended by using this approach:
In order to request PostgreSQL to do a case insensitive sort for all string columns of a model at once, Ransack can be extended by using this approach:

```ruby
module RansackObject
Expand Down
2 changes: 1 addition & 1 deletion lib/ransack/adapters/active_record/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def ransackable_scopes(auth_object = nil)
end

# ransack_scope_skip_sanitize_args, by default, returns an empty array.
# i.e. use the sanitize_scope_args setting to determin if args should be converted.
# i.e. use the sanitize_scope_args setting to determine if args should be converted.
# For overriding with a list of scopes which should be passed the args as-is.
#
def ransackable_scopes_skip_sanitize_args
Expand Down
2 changes: 1 addition & 1 deletion spec/polyamorous/join_association_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module Polyamorous
expect(subject).not_to eq new_join_association(reflection, parent.children, Article)
end

it 'leaves the orginal reflection intact for thread safety' do
it 'leaves the original reflection intact for thread safety' do
reflection.instance_variable_set(:@klass, Article)
join_association
.swapping_reflection_klass(reflection, Person) do |new_reflection|
Expand Down