Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing non-casted array predicates. Resolves issue #1245 #1246

Merged

Conversation

danielpclark
Copy link
Contributor

@danielpclark danielpclark commented Aug 24, 2021

Have casted array predicates type checked to Arel::Nodes::Casted fixing non-casted array predicates.

@danielpclark danielpclark changed the title Resolves issue #1245 Fixing non-casted array predicates. Resolves issue #1245 Aug 26, 2021
@@ -2,6 +2,9 @@

* Drop support for rubies under 2.5. PR #1189

* Have casted array predicates type checked to Arel::Nodes::Casted fixing non-casted array predicates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea: adding to the Changelog as part of the PR.

@scarroll32 scarroll32 merged commit 81910c2 into activerecord-hackery:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants