Drop rails 5.2 support #1276
Merged
Drop rails 5.2 support #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
drop-rails-5.2-support
branch
from
49811b7 to
aa4caf5
Compare
|
@deivid-rodriguez this works for me, but can we hold off for a week or so? |
|
You mean for releasing this? Sure! I can do the release myself too if necessary. |
|
@deivid-rodriguez thanks for holding. Feel free to merge this once the conflicts are resolved. |
We only support Rails versions higher than this.
It only runs on Rails 5.1 or older, no longer supported.
deivid-rodriguez
force-pushed
the
drop-rails-5.2-support
branch
from
aa4caf5 to
feed41c
Compare
|
Great, I resolved conflicts and will merge after CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to drop support for Rails 5.2. It's very old.