Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude "host" from params sent to url generator #1317

Merged
merged 1 commit into from
May 8, 2022
Merged

Exclude "host" from params sent to url generator #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ransack/helpers/form_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def name

def url_options
@params.merge(
@options.except(:class, :data).merge(
@options.except(:class, :data, :host).merge(
@search.context.search_key => search_and_sort_params))
end

Expand Down
12 changes: 12 additions & 0 deletions spec/ransack/helpers/form_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,18 @@ module Helpers
it { should_not match /people\?data%5Bturbo_action%5D=advance/ }
end

describe "#sort_link with host option" do
subject { @controller.view_context
.sort_link(
[:main_app, Person.ransack(sorts: ['name desc'])],
:name,
host: 'foo', controller: 'people'
)
}
it { should match /href="\/people\?q/ }
it { should_not match /href=".*foo/ }
end

describe '#search_form_for with default format' do
subject { @controller.view_context
.search_form_for(Person.ransack) {} }
Expand Down