Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Polyamorous entrypoint #1370

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Remove Polyamorous entrypoint #1370

merged 1 commit into from
Nov 9, 2022

Conversation

scarroll32
Copy link
Member

@scarroll32 scarroll32 commented Nov 8, 2022

Extracted from #1348

I think we can hold it until you can have a look. Breaking require "polyamorous" could be considered a breaking change so I'd ship it with 4.0.0 too.

Should we make the next release 4.0.0 ? @deivid-rodriguez ?

@scarroll32 scarroll32 changed the title Remove Polyamorous enntrypoint Remove Polyamorous entrypoint Nov 8, 2022
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a look at other issues and what we have pending to release first. So I would mark as breaking and merge for now, and then see if it's time for 4.0.0 or we should create a stable branch and backport some stuff first.

But if you feel confident to do this and release now, please go ahead!

@scarroll32
Copy link
Member Author

I'd like to have a look at other issues and what we have pending to release first. So I would mark as breaking and merge for now, and then see if it's time for 4.0.0 or we should create a stable branch and backport some stuff first.

But if you feel confident to do this and release now, please go ahead!

@deivid-rodriguez what if we mark it a breaking and merge to main, and then release 4.0.0 closer to the end of the year?

@deivid-rodriguez
Copy link
Contributor

The thing is I'm finding trouble to dedicate to Ransack lately, so I can't really commit to any date.

My advice is, if dropping this is the only thing we have for 4.0, it makes no sense to release 4.0 yet. I don't recall what other stuff we had pending a release.

@scarroll32
Copy link
Member Author

The thing is I'm finding trouble to dedicate to Ransack lately, so I can't really commit to any date.

My advice is, if dropping this is the only thing we have for 4.0, it makes no sense to release 4.0 yet. I don't recall what other stuff we had pending a release.

I understand @deivid-rodriguez, I don't think we have anything else just yet, so let's just leave it "for a while" and we can cut a new release in a few months or whenever we think best. No stress!

Thank you for all of your contributions to Ransack 🚀

@scarroll32 scarroll32 merged commit c08b4c4 into main Nov 9, 2022
@scarroll32 scarroll32 deleted the remove-polyamorous branch November 9, 2022 13:38
@scarroll32 scarroll32 mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants