Failing test cases for when 0 and 1 are passed to non-boolean scopes #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is passing except that your tests expect See #507 |
|
Ah, never mind. I see this should be an integer count... |
|
Derp, yes you got it Jared! |
|
Actually @jaredbeck I meant #502 ! |
|
Looking at this again after a long while... I don't think Ransack should be responsible for converting params anymore, this should probably be happening in the controller anyway. We should probably just support this without getting too clever:
|
This was referenced Feb 17, 2016
|
Superseded by #742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@avit, may we re-open #504 based on these failing test cases?