Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowing ':wants_array' to be passed as 'false' in predicate options #523

Merged
merged 1 commit into from
Mar 24, 2015
Merged

allowing ':wants_array' to be passed as 'false' in predicate options #523

merged 1 commit into from
Mar 24, 2015

Conversation

Pavling
Copy link
Contributor

@Pavling Pavling commented Mar 19, 2015

Addressing #32

@jonatack
Copy link
Contributor

@Pavling this looks good. Could you rebase against master?

@Pavling Pavling force-pushed the predicate-wants-array-false-option branch from 8b2c87c to 0abaab4 Compare March 24, 2015 09:03
@Pavling
Copy link
Contributor Author

Pavling commented Mar 24, 2015

Cheers, Rebased and pushed back up to my fork's branch.

@jonatack
Copy link
Contributor

Awesome job. Nice touch using fetch. Thanks for adding missing tests that we didn't have, in addition to testing this feature and for adding specs for both Mongoid and Active Record.

jonatack added a commit that referenced this pull request Mar 24, 2015
@jonatack
Merge pull request #523 from Pavling/predicate-wants-array-false-option
f78e34f 
Allow ':wants_array' to be passed as 'false' in predicate options.
@jonatack jonatack merged commit f78e34f into activerecord-hackery:master Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pavling @jonatack