Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] German locale file (de.yml) #537

Merged
merged 2 commits into from
May 31, 2015

Conversation

wpp
Copy link
Contributor

@wpp wpp commented May 8, 2015

Hallo,

I've noticed there were no German translations.
I've read and followed your Contributing guide, hopefully I didn't miss anything.

  • Some translations sound a bit "odd"
  • Spell-checked

Enjoy your weekend!

Cheers,
Philipp

@wpp wpp force-pushed the german_locale branch from 7178c87 to db919e1 Compare May 8, 2015 13:52
@jonatack
Copy link
Contributor

jonatack commented May 8, 2015

Hi @wpp, thank you! Did you compare with this German translation for Ransack?

@wpp
Copy link
Contributor Author

wpp commented May 11, 2015

Hi, just did I've changed a few but also kept a couple (I believe mine are more concise and fitting for ransack). Let me know if you disagree.

jonatack added a commit that referenced this pull request May 31, 2015
[skip ci] German locale file (de.yml)
@jonatack jonatack merged commit d5d1cfa into activerecord-hackery:master May 31, 2015
@jonatack
Copy link
Contributor

I'll have to take your word for it ;) thanks for the PR!

jonatack added a commit that referenced this pull request Jul 18, 2015
Completes PRs #562, #498, #426, #560 and #537 among others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants