Fix time-dependent test failure #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
added a commit
that referenced
this pull request
Jul 11, 2015
Fix time-dependent test failure
|
Thanks @avit! |
|
Could you update the change log with your fix? |
| @@ -145,6 +145,9 @@ def self.sane_adapter? | |||
| end | |||
|
|
|||
| it "should function correctly with a multi-parameter attribute" do | |||
| ::ActiveRecord::Base.default_timezone = :utc | |||
There was a problem hiding this comment.
Would have been better to have this in config/environments/test.rb, as this could lead to unexpected behaviour for other specs.
There was a problem hiding this comment.
Hm... a different TZ is set in spec_helper.rb as well. Suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the database has
default_timezone = :local(system time) and the Time.zone is set to elsewhere thenDate.currentdoes not match what the query produces for the stored timestamps.Resolved by setting everything to UTC.