Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing boolean values to scopes #575

Closed
wants to merge 2 commits into from
Closed

Passing boolean values to scopes #575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb3ac9
Added failing tests and todo message for passing boolean values to sc…
MarcelEeken Aug 18, 2015
6365855
Small typo fix
MarcelEeken Aug 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions spec/ransack/adapters/active_record/base_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,19 @@ module ActiveRecord
expect(s.result.to_sql).to (include 'age > 18')
end

# TODO: Implement way to pass true or false values to scopes that
# requires arguments

# it "passes true values to scopes", focus: true do
# s = Person.ransack('over_age' => 1)
# expect(s.result.to_sql).to (include 'age > 1')
# end

# it "passes false values to scopes", focus: true do
# s = Person.ransack('over_age' => 0)
# expect(s.result.to_sql).to (include 'age > 0')
# end

it "chains scopes" do
s = Person.ransack('over_age' => 18, 'active' => true)
expect(s.result.to_sql).to (include 'age > 18')
Expand Down