-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functionality to hide all search indicator arrows via config #577
Closed
josh-hunter-software
wants to merge
11
commits into
activerecord-hackery:master
from
josh-hunter-software:hide_search_indicator_in_config
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5ad4f4e
add functionality to hide all search indicator arrows via config
5749940
Update form_helper_spec.rb
kalami 3e6ee03
Update README.md
kalami aad81ba
Update README.md
kalami 354827a
moved logic for setting @hide_indicator into a seperate method, impro…
08bcad7
updated the specs to reflect new config option name
237fc64
removed merge comments from form_helper_spec.rb
0c74241
[skip ci] set line to 80 characters and added backticks to identify i…
e0c8eba
removed indicator? method and updated readme.md
aebfead
added parens for @hide_indicator in SortLink#initialize; corrected th…
d99a6de
moved sort_link hide_sort_order_indicator specs up with the other sor…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,8 @@ module Configuration | |
self.predicates = {} | ||
self.options = { | ||
:search_key => :q, | ||
:ignore_unknown_conditions => true | ||
:ignore_unknown_conditions => true, | ||
:hide_sort_order_indicators => false | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps call it |
||
|
||
def configure | ||
|
@@ -75,5 +76,9 @@ def arel_predicate_with_suffix(arel_predicate, suffix) | |
end | ||
end | ||
|
||
def hide_sort_order_indicators=(boolean) | ||
self.options[:hide_sort_order_indicators] = boolean | ||
end | ||
|
||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use markdown ruby code format block for the config code example (3 backticks + 'ruby' ... code ... 3 backticks).
code