Add block argument for sort_link #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalpo
force-pushed
the
feature/sort-link-block
branch
from
4377fd5 to
2e6667b
Compare
|
Uhm.. Failures don't depend on my commit 🐛 It seems that the rack-cache gem has been changed and now require at least ruby 2.0 btw, let me know what do you think about this PR 😉 |
|
Thanks! Will have a look soon. |
jonatack
added a commit
that referenced
this pull request
Dec 23, 2015
Add block argument for sort_link
|
@dalpo Very sorry for not getting back to your PR much sooner. It looks good 💜 🚀 Would you like to make a PR to update the README and Change Log? |
Merged
|
Sure! Here you can find the PR #630 |
jonatack
added a commit
that referenced
this pull request
Jan 1, 2016
[skip ci] Update changelog (follow-up to #604).
dalpo
added a commit
to dalpo/ransack
that referenced
this pull request
Jan 2, 2016
jonatack
added a commit
that referenced
this pull request
Jan 2, 2016
jonatack
added a commit
that referenced
this pull request
Jan 13, 2016
Use main repository link in CHANGELOG.md. Follow-up to #604.
avit
added a commit
to avit/ransack
that referenced
this pull request
Feb 19, 2016
* master: (133 commits) Use main repository link in CHANGELOG.md. Update documentation with Mongoid 5 support. Support Mongoid 5. Remove inline conditional from constructor back to private method Rails 5 params: instance_variable_get -> to_unsafe_h Add README doc and fix CHANGELOG for PR activerecord-hackery#604 [skip ci] Travis-ci: expect Rails 3.1/3.2 with Ruby 2.3.0 to pass. This was moved from Squeel to Polyamorous [skip ci] Update changelog Gemfile: bump Mongoid back down to v4 Wrap lines at 80 chars Fix specs broken by Rails 3 on Ruby 2.3.0. Do not run the datetime_select spec when Rails 3.1 && Ruby 2.3.0 Gemfile: bump Mongoid from 4 to 5 Allow Travis failures for Rails 3 with Ruby 2.3 until debugged Test all versions with Ruby 2.3.0 Remove copyright from README; it is already in the LICENSE file. Remove unneeded `before` block test setup Simplify doc comment, wraps to 80 chars [skip ci] Fix Adapters::ActiveRecord::Context for Rails 5 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing block argument to the sort_link method: