Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese yml file #622

Merged

Conversation

masajames1016
Copy link

Added Japanese locale.
Hope you like it.

@masajames1016 masajames1016 changed the title Add japanese yml file Add Japanese yml file Dec 7, 2015
@jonatack
Copy link
Contributor

jonatack commented Dec 7, 2015

@masacandy Thanks! Could you update the change log file with your contribution and we'll merge it in.

@jonatack
Copy link
Contributor

jonatack commented Dec 7, 2015

You can use [skip ci] in your change log commit message so the travis tests don't 🏃 needlessly.

@masajames1016
Copy link
Author

@jonatack Thanks for your replay. I updated the change log (forgot to add [skip ci] though...)

@jonatack
Copy link
Contributor

jonatack commented Dec 7, 2015

Could you push your change log update to the same branch? I don't see it here. Thanks!

@masajames1016
Copy link
Author

I think I had misunderstood... but I did as you want this time probably

jonatack added a commit that referenced this pull request Dec 8, 2015
@jonatack jonatack merged commit da0d0e8 into activerecord-hackery:master Dec 8, 2015
@jonatack
Copy link
Contributor

jonatack commented Dec 8, 2015

All good, thank you @masacandy :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants