Ensure conditions differing only by ransacker_args aren't filtered out by uniq! #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ajporterfield for your PR! Sorry for the delay, will review it shortly. |
|
Thanks again 🍰 |
jonatack
added a commit
that referenced
this pull request
May 12, 2016
prasadsurase
pushed a commit
to prasadsurase/ransack
that referenced
this pull request
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a setup similar to http://ransack-demo.herokuapp.com/users/advanced_search. We use ransackers + ransacker_args to create "virtual" attributes - by that I mean attributes that have the same name, but are passed different ransacker_args. One scenario for us is total_donations_over_time, which is a ransacker that takes a date range as its ransacker_args. We have "Total donations this year" and "Total donations last year" in our attributes dropdown, but they both map to total_donations_over_time. Anyways, I found that subsequent conditions having the same attribute name, predicate, and value were getting removed by self.conditions.uniq! even if they had different ransacker_args. This patch fixes the issue by passing a block to uniq!.