use ActiveSupport.on_load to hook into Active Record
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For avoiding autoloading these constants too soon. This affect the initialization of Active Record. Ref: rails/rails#23589 (comment)
|
Thanks @y-yagi! |
|
@jonatack Thank you for your confirmation! |
|
I think this commit may have broken the mongoid adapter |
|
could we just add a bindable.rb to the mongoid adapter and override is_alias_attribute? to return false? |
|
Thank you pointed out! I think you are correct. I will fix. |
y-yagi
added a commit
to y-yagi/ransack
that referenced
this pull request
Sep 16, 2016
In activerecord-hackery#719, the definition of `Ransack::SUPPORTS_ATTRIBUTE_ALIAS` has changed when Active Record is loaded. In the impact, `Ransack::SUPPORTS_ATTRIBUTE_ALIAS` in mongo adapter has become no longer be defined, modify to defined in mongoid adapter. Follow up to activerecord-hackery#719
prasadsurase
pushed a commit
to prasadsurase/ransack
that referenced
this pull request
Sep 22, 2016
|
Thank you @jdguzman for reporting. |
|
This affects my rails 5 project, any plans for releasing this..? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For avoiding autoloading these constants too soon.
This affect the initialization of Active Record.
Ref: rails/rails#23589 (comment)