Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixed: Rails 4.2: NoMethodError: undefined method asc for #<Arel::Nod…" #869

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

scarroll32
Copy link
Member

Reverts #600

@scarroll32
Copy link
Member Author

Errors on merge to master

@roman-franko
Copy link
Contributor

roman-franko commented Feb 6, 2018

Hi seanfcarroll,
Could you clarify, please, what exactly errors happened?

@scarroll32 scarroll32 merged commit 2bbfa4d into master Feb 7, 2018
@scarroll32
Copy link
Member Author

Hi @roman-franko it seems to be OK now, possibly as a result of #875

I created a new PR from your repo and have merged it. Will cut the new release of the gem soon, but for now, you can track master.

Thank you for your contributions.

@scarroll32 scarroll32 deleted the revert-600-master branch February 7, 2018 12:55
@roman-franko
Copy link
Contributor

roman-franko commented Feb 9, 2018

Hi @seanfcarroll,
Sorry, but it looks like wrong commit in activerecord-hackery/ransack .
fa6f8a5

This is the correct one: roman-franko@c06120b

@roman-franko
Copy link
Contributor

Can I fix it by myself?

@scarroll32
Copy link
Member Author

scarroll32 commented Feb 9, 2018 via email

tekniklr pushed a commit to tekniklr/ransack that referenced this pull request Mar 19, 2021
…/revert-600-master

Revert "Fixed: Rails 4.2: NoMethodError: undefined method asc for #<Arel::Nod…"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants