absorb polyamorous #927
Merged
absorb polyamorous #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is caused by this: rails/rails@50036e6?diff=unified |
|
Great work @gregmolnar ! The CI is still running which is strange, but I will check in later and merge it if all green. |
|
@seanfcarroll I just pushed a commit, that's why it is running again. There is a breaking change on Rails 5-2-stable unfortunately, so I changed the travis config to test agains 5.2.0 and allow failures on 5-2-stable. |
gregmolnar
force-pushed
the
polyamorous
branch
3 times, most recently
from
4492331 to
8f4552e
Compare
|
Thanks @gregmolnar this one was a long time coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is in the readme, the next major release should absorb polyamorous.
/cc @seanfcarroll