Add feature to allow selectively skipping scope argument sanitization. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinh24
changed the title
gregmolnar
reviewed
Jul 19, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # Change Log | |||
|
|
|||
| ## Version | |||
|
|
|||
| ### Added | |||
CHANGELOG.md
Outdated
|
|
||
| * Add the ability to skip arg sanitization on a per scope basis. Using | ||
| `ransackable_scopes_skip_sanitize_args`, users can define a list of | ||
| scopes which will bypass parameter sanitization. This allows passing 0, |
There was a problem hiding this comment.
There is an extra space before This allows
| @@ -64,6 +64,14 @@ def ransackable_scopes(auth_object = nil) | |||
| [] | |||
| end | |||
|
|
|||
| # ransack_scope_skip_sanitize_args, by efault, returns an empty array. | |||
There was a problem hiding this comment.
there is a typo at by default
|
@justinh24 Thanks for your contribution! It is looking good to me, I just found a few copy issues. |
|
@justinh24 thanks! Could you please squash the 2 commits and I will merge it, thank you! |
justinh24
force-pushed
the
selectively_skip_scope_sanitizing
branch
from
f1e65ba to
b006677
Compare
Fixed copy issues
justinh24
force-pushed
the
selectively_skip_scope_sanitizing
branch
from
b006677 to
24a4d43
Compare
|
@gregmolnar Sorry about forgetting to squash. Hopefully this will be good now. Thanks! |
|
Hmm.. there were no changes other than merges than squashing the branches. Is this a travis error? It looks like a possible timeout. |
|
Looks like a timeout indeed. I restarted it, let's see if that helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Ransack documentation suggests you implement your own sanitization if you need the ability to pass truth-y values to a scope (1,0,t,f,etc.). I have provided an add one to allow one to list scopes which should not be sanitized, and to continue using the existing mechanism for all other scopes.
This is particularly handy if you are passing form inputs into a scope. (i.e. Power Search which searches across multiple fields)