Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Sort with existing join on same table #935

Closed
wants to merge 2 commits into from
Closed

Fix for Sort with existing join on same table #935

wants to merge 2 commits into from

Conversation

chopraanmol1
Copy link
Contributor

@chopraanmol1 chopraanmol1 commented Jul 26, 2018 •
edited
Loading

Fix for #936

Working example

Comment.ransack(article_title_cont: 'aven',s: 'person_salary desc').result
Comment.joins(:person).ransack(s: 'person_salary desc', article_title_cont: 'aven').result

Failing Example

Comment.joins(:person).ransack(article_title_cont: 'aven',s: 'person_salary desc').result

@chopraanmol1 chopraanmol1 changed the title Sort with join on existing table does not work Fix for Sort with join on existing table Jul 26, 2018
@chopraanmol1 chopraanmol1 changed the title Fix for Sort with join on existing table Fix for Sort with existing join on same table Jul 26, 2018
@gregmolnar
Copy link
Member

@chopraanmol1 Thank you for your contribution! This needed a large rebase, so I am closing it and pulled in your changes in #937

@gregmolnar gregmolnar closed this Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chopraanmol1 @gregmolnar