Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create output folder if missing #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rgosse
Copy link
Collaborator

@rgosse rgosse commented Oct 21, 2020

Creates the ouput folder if missing

@@ -1,6 +1,6 @@
{
"name": "react-api-documenter",
"version": "0.0.4",
"version": "0.0.5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be updated.
The easiest to avoid this kind of problem would be to not change the version in functional pull requests, and only do it in separate PRs, while releasing this module.

@@ -30,6 +30,12 @@ export const generateMarkdown = async (

const items = getApiItems(apiPackage, ignorePattern);

await stat(outputFolder, (err) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await stat(outputFolder, (err) => {
await ensureDir(outputFolder);

with ensureDir from fs-extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants