#Issue1133 : Expand PasswordResetSerializer for backend

[narmadha-raghu]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have run the tests for the backend and frontend depending on what's needed for my changes as described in the testing section of the contributing guide

PFA

---

Description

This pull request improves test coverage in backend/authentication/serializers.py, specifically addressing the missing lines 111-114 in the PasswordResetSerializer. I have added test cases to ensure these lines are covered.

Changes :

• Added missing tests for PasswordResetSerializer to achieve full coverage.
• Ensured proper validation and error handling are tested.

Testing :

• Verified that all tests pass successfully.

I followed this resource, as suggested by @andrewtavis, to refine the test implementation for DRF serializers.

• Expand Serializers testing for backend #1133

[netlify]

✅ Deploy Preview for activist-org canceled.

Name	Link
🔨 Latest commit	01d5bda
🔍 Latest deploy log	https://app.netlify.com/sites/activist-org/deploys/67cde339b3a03e0008564786

[github-actions]

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

• The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

• The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[github-actions]

First PR Commit Check

• The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo (can be set with git config --global user.email "GITHUB_EMAIL")

[andrewtavis]

Thanks for the PR, @narmadha-raghu! We'll try to get to this in the coming days :)

CC @to-sta for oversight here. The method resources that I provided was this blog post, which may also then be used in other Serializers so we're consistent.

[narmadha-raghu]

Hi @andrewtavis,

I also have another question—would it be a good idea to split the tests within authentication for better organization?

For example, we could structure them under a tests/ folder, separating them into files like:

• test_auth.py (for authentication-related tests)
• test_serializer.py (for serializer-specific tests)

This would make the implementation clearer and more maintainable. Let me know your thoughts! 🚀

[andrewtavis]

That sounds amazing to me, @narmadha-raghu! Feel free to send along this refactor and then we'll get to the review :)

[andrewtavis]

Thanks for the great initiative! 😊