Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macro compile tests #133

Merged
merged 1 commit into from
Apr 29, 2020
Merged

add macro compile tests #133

merged 1 commit into from
Apr 29, 2020

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Apr 24, 2020

Add compile tests using trybuild.

@robjtede robjtede changed the title add compile tests add macro compile tests Apr 24, 2020
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #133 into master will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   61.27%   61.09%   -0.19%     
==========================================
  Files          79       80       +1     
  Lines        5012     5017       +5     
==========================================
- Hits         3071     3065       -6     
- Misses       1941     1952      +11     
Impacted Files Coverage Δ
string/src/lib.rs 80.23% <ø> (ø)
actix-macros/tests/trybuild.rs 100.00% <100.00%> (ø)
actix-rt/src/runtime.rs 71.42% <0.00%> (-7.15%) ⬇️
actix-utils/src/task.rs 68.75% <0.00%> (-6.25%) ⬇️
actix-utils/src/counter.rs 89.28% <0.00%> (-3.58%) ⬇️
actix-server/src/server.rs 60.00% <0.00%> (-2.86%) ⬇️
actix-server/src/service.rs 70.83% <0.00%> (-2.09%) ⬇️
actix-connect/src/connector.rs 49.01% <0.00%> (-1.97%) ⬇️
actix-utils/src/oneshot.rs 94.69% <0.00%> (-1.77%) ⬇️
actix-utils/src/timeout.rs 65.07% <0.00%> (-1.59%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0cfe1...4c5568e. Read the comment docs.

@robjtede
Copy link
Member Author

robjtede commented Apr 26, 2020

Not been having fun trying to wrangle compiletest and from what I have seen, it's output is distinctly less useful.

Feelings somewhat match this comment: dtolnay/trybuild#13 (comment)

@robjtede robjtede marked this pull request as ready for review April 26, 2020 17:32
@robjtede robjtede requested a review from JohnTitor April 26, 2020 17:33
@robjtede robjtede marked this pull request as draft April 26, 2020 18:38
@robjtede robjtede marked this pull request as ready for review April 26, 2020 19:11
@robjtede
Copy link
Member Author

thanks to some swift changes to trybuild this PR should be ready now that windows CI failures have been addressed.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JohnTitor JohnTitor merged commit 700997f into master Apr 29, 2020
@JohnTitor JohnTitor deleted the macro-compile-testing branch April 29, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants