Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry on EINTR in accept loop #264

Merged
merged 4 commits into from
Feb 4, 2021
Merged

retry on EINTR in accept loop #264

merged 4 commits into from
Feb 4, 2021

Conversation

shuoli84
Copy link
Contributor

@shuoli84 shuoli84 commented Feb 3, 2021 •
edited
Loading

PR Type

Bug Fix

PR Checklist

  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Currently, EINTR which equals std::io::ErrorKind::Interrupted will trigger a panic. This change captures it and retry poll.

closes #263

robjtede
robjtede requested changes Feb 4, 2021
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Can you add a changelog entry. No testing required for this.

actix-server/src/accept.rs Outdated Show resolved Hide resolved
robjtede
robjtede approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks 👍🏻

@robjtede robjtede merged commit db3385e into actix:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'actix-server accept loop' panic when resuming from sleep
2 participants
@shuoli84 @robjtede