Fix worker are notified to stop with non_graceful shutdown #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This changes the behavior of server as force shutdown was not exiting worker threads. There could be people using it as a feature rather than bug. |
robjtede
reviewed
Apr 15, 2021
|
|
||
| if exit { | ||
| sleep(Duration::from_millis(300)).await; | ||
| System::current().stop(); |
There was a problem hiding this comment.
should we code this as try_current ?
There was a problem hiding this comment.
Right now we still expect system when running a server so I think it's fine here.
We can change when actix-rt is made optional.
There was a problem hiding this comment.
The thing I have no idea is why there is 300 ms delay.
robjtede
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bug Fix
PR Checklist
Check your PR fulfills the following:
Overview
With non graceful shutdown there is no signal for notify worker threads to exit. This could result in leak of worker threads.
This PR changes to notify worker threads to shutdown on all cases. But only in graceful shutdown case server builer wait for worker shutdown response.