Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ServerBuilder::configure #349

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Conversation

fakeshadow
Copy link
Contributor

@fakeshadow fakeshadow commented Apr 26, 2021

PR Type

Refactor

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Remove ServerBuilder::configure API and config module.

Reason:

  1. There is one potential footgun with config module. It's that it pack multiple service factory calls into one future. This result in any failure of service would trigger restart of all the packed services. This could be an issue when service factories have dependent on external state.

  2. actix-server right now have a strict 1:1 mapping between socket and service. This lead to duplicated service types across worker threads and preventing service state share when multiple sockets can/should share one service. config module get in the way of resolving this issue as it has a unique set of API.

  3. Nothing use config module.

The removal would be tempoaray until socket/service mapping is figured out.

@robjtede robjtede merged commit 8ad5f58 into master Apr 27, 2021
@robjtede robjtede deleted the remove/server_config_module branch April 27, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants