Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
Check your PR fulfills the following:
Overview
Remove
ServerBuilder::configure
API andconfig
module.Reason:
There is one potential footgun with
config
module. It's that it pack multiple service factory calls into one future. This result in any failure of service would trigger restart of all the packed services. This could be an issue when service factories have dependent on external state.actix-server
right now have a strict 1:1 mapping between socket and service. This lead to duplicated service types across worker threads and preventing service state share when multiple sockets can/should share one service.config
module get in the way of resolving this issue as it has a unique set of API.Nothing use
config
module.The removal would be tempoaray until socket/service mapping is figured out.