router: fix multi-pattern and path tail matches

[aliemjay]

PR Type

Bug fix

PR Checklist

Check your PR fulfills the following:

• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt

Overview

In muti-pattern, static patterns are accidentaly interpreted as regex. This is fixed by adding a flag to parse() (force_dynamic) to force it to always escape and render the pattern as regex even when it is static.

This also fixes the case when static path tail (/*) is used after a dynamic segment:

/static/* ... already works
/{user}* ... already works; stores the path tail in user
/{user}/* ... doesn't work as expected.

Please see failing tests and linked issue.

Closes actix/actix-web#1647

[aliemjay]

@robjtede I added one more commit of related refactoring. I'm unsure if you want it in another PR.

[robjtede]

great work