system: run and return exit code on stop #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an additional running method to `System`, which allows consumers to retrieve the stopping code. Additionally, the existing `run()` is reworked to use that internally, ensuring both codepaths are tested and aligned in behavior.
|
change to match terminology: |
|
Thanks for the tweaks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds an additional running method to
System, which allowsconsumers to retrieve the stopping code.
Additionally, the existing
run()is reworked to use thatinternally, ensuring both codepaths are tested and aligned in
behavior.
PR Type
PR Checklist
Check your PR fulfills the following:
run()rework.