add MPTCP socket protocol (optional) #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: this PR will fail until socket2 make a new release with the new Protocol::MPTCP, but the content can still be reviewed |
Martichou
added a commit
to Martichou/actix-web
that referenced
this pull request
Sep 10, 2022
Add the possibility to use the MPTCP protocol. (recently added here too: actix/actix-net#466) Check the link above (PR 466) to see the details about this change (it's pretty much the same). Signed-off-by: Martin Andre <martin.andre@tessares.net>
Martichou
added a commit
to Martichou/actix-web
that referenced
this pull request
Sep 10, 2022
Add the possibility to use the MPTCP protocol. (recently added here too: actix/actix-net#466) Check the link above (PR 466) to see the details about this change (it's pretty much the same). Signed-off-by: Martin Andre <martin.andre@tessares.net>
|
Unfortunately, the I see there was a comment |
Add the possibility to use the MPTCP protocol at the socket level for users of ServerBuilder. MPTCP is now more widely available since Linux Kernel version >= 5.6. But it still need to be enabled manually using: `sysctl net.mptcp.enabled=1`. (of course, MPTCP is only available on Linux) The new MPTCP struct give the user the option to determine how we'll handle the case where MPTCP is not available on the host, either we crash, or we fallback to regular TCP. Signed-off-by: Martin Andre <martin.andre@tessares.net>
Signed-off-by: Martichou <m@rtin.fyi>
|
Thanks for pushing this. My tweaks are mostly mechanical. We're expecting Windows CI failures atm so no worries there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
Overview
Add the possibility to use the MPTCP protocol at the socket level for users of ServerBuilder.
MPTCP is now more widely available since Linux Kernel version >= 5.6. But it still need to be enabled manually using:
sysctl net.mptcp.enabled=1(of course, MPTCP is only available on Linux).The new MPTCP struct give the user the option to determine how we'll handle the case where MPTCP is not available on the host, either we crash, or we fallback to regular TCP.