-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade socket2 dependency #1803
Conversation
Upgrades to a version not making invalid assumptions about the memory layout of std::net::SocketAddr
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
+ Coverage 53.76% 53.80% +0.04%
==========================================
Files 132 129 -3
Lines 12278 12266 -12
==========================================
- Hits 6601 6600 -1
+ Misses 5677 5666 -11
Continue to review full report at Codecov.
|
Since we don't lock |
Cargo only tries to pull the latest version when you have no lockfile. Anyone with a lockfile will continue to pull the version they already have until they do The faster we can make the community adopt these fixed versions the faster the linked to PR on the standard library can advance. Other crates that accepted the same type of bump in order to help out with adoption rate: alexcrichton/curl-rust#365, hyperium/hyper#2349 and rust-lang/cargo#8909 |
But then you should do |
Thank you! |
Yep I agree with this merge, in this case. |
PR Type
Bug Fix / Other: Upgrades a dependency to a version not making invalid assumptions about the memory layout of standard library types (
std::net::SocketAddr
).Helps unblock rust-lang/rust#78802. See that PR for more details. This PR simply helps adoption of the fixed version(s) of
socket2
.