Skip to content

Conversation

@SabrinaJewson
Copy link
Contributor

@SabrinaJewson SabrinaJewson commented May 30, 2022

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
    • N/A? I can’t really add tests that wouldn’t just be repeating what the code says
  • Documentation comments have been added / updated.
    • Also N/A IMO, I don’t think it really needs docs
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

I saw someone on Discord encounter a problem because it wasn’t present earlier today. It seems reasonable, so I added it. The use case was in the Result returned from actix_form_data::Field::file.

@robjtede robjtede added A-web project: actix-web B-semver-minor labels May 30, 2022
@robjtede robjtede added this to the actix-web v4.1 milestone May 30, 2022
@SabrinaJewson
Copy link
Contributor Author

Ah…CI is failing but it doesn’t seem to be related to this PR, just that hashbrown no longer compiles on the MSRV.

Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat change. Thank you 👍

We'll sort through CI later.

@robjtede robjtede merged commit dce57a7 into actix:master May 30, 2022
@SabrinaJewson SabrinaJewson deleted the infallible-response-error branch May 30, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-web project: actix-web B-semver-minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants