fix pending stream drop #2830
Open
fix pending stream drop #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simorex80
force-pushed
the
fix/pending-stream-drop
branch
from
645f33b to
fbe1bd6
Compare
simorex80
force-pushed
the
fix/pending-stream-drop
branch
from
85e566a to
7452ef2
Compare
|
Any ideas when this PR might be closed/merged? |
|
It's waiting on a test case demonstrating the fix. |
|
It's needed something from my side?
Il lun 5 giu 2023, 19:45 Rob Ede ***@***.***> ha scritto:
… It's waiting on a test case demonstrating the fix.
—
Reply to this email directly, view it on GitHub
<#2830 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATXPXPHTPTKEFBODMCDEAJ3XJYLLVANCNFSM553IGQJQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The test case demonstrating the fix, I'm guessing! |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
But Fix
PR Checklist
Tests for the changes have been added / updated.Overview
Fix the problem described in bug:
A Stream object in a pending state won't be dropped after the client disconnect #1313
When the disconnection events is triggered, no state check is needed.
The streaming process, due no access to TcpStream, don't have the necessary elements to change the state and this caused the stuck described in the bug.
Closes #1313