Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): don't use variables to install rust nightly #3533

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(ci): don't use variables to install rust nightly, as other cont…
…ributors cannot access them
joelwurtz committed Dec 16, 2024
commit 1bfcce7d8eec43f79779c58e502d32380dcdfd69
10 changes: 5 additions & 5 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -71,10 +71,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Install Rust (${{ vars.RUST_VERSION_EXTERNAL_TYPES }})
- name: Install Rust nightly
uses: actions-rust-lang/setup-rust-toolchain@v1.10.1
with:
toolchain: ${{ vars.RUST_VERSION_EXTERNAL_TYPES }}
toolchain: nightly-2024-10-18

- name: Install just
uses: taiki-e/install-action@v2.45.6
@@ -87,7 +87,7 @@ jobs:
tool: cargo-check-external-types

- name: check external types
run: just check-external-types-all +${{ vars.RUST_VERSION_EXTERNAL_TYPES }}
run: just check-external-types-all +nightly-2024-10-18

public-api-diff:
runs-on: ubuntu-latest
@@ -100,10 +100,10 @@ jobs:
- name: Checkout PR branch
uses: actions/checkout@v4

- name: Install Rust (${{ vars.RUST_VERSION_API_DIFF }})
- name: Install Rust nightly
uses: actions-rust-lang/setup-rust-toolchain@v1.10.1
with:
toolchain: ${{ vars.RUST_VERSION_API_DIFF }}
toolchain: nightly-2024-10-18

- name: Install cargo-public-api
uses: taiki-e/install-action@v2.45.6