Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove incomplete initialisation from InterpolatedBFieldMap #1467

Merged
merged 4 commits into from
Jun 14, 2023
Merged

fix: Remove incomplete initialisation from InterpolatedBFieldMap #1467

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2138bc8
Remove InterpolatedBFieldMap boundary check, using under/overflow bin…
Aug 25, 2022
e8ec0ca
Merge branch 'main' into bfield-nobounds
timadye Jun 14, 2023
f596fd2
restore OutOfBounds check. assert if neighbors array not fully filled.
Jun 14, 2023
a9a4042
Merge branch 'main' into bfield-nobounds
kodiakhq[bot] Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Core/include/Acts/MagneticField/InterpolatedBFieldMap.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ class InterpolatedBFieldMap : public InterpolatedMagneticField {

// loop through all corner points
constexpr size_t nCorners = 1 << DIM_POS;
std::array<Vector3, nCorners> neighbors{Vector3{0.0, 0.0, 0.0}};
std::array<Vector3, nCorners> neighbors;
const auto& cornerIndices = m_cfg.grid.closestPointsIndices(gridPosition);

if (!isInsideLocal(gridPosition)) {
Expand All @@ -211,6 +211,8 @@ class InterpolatedBFieldMap : public InterpolatedMagneticField {
neighbors.at(i++) = m_cfg.transformBField(m_cfg.grid.at(index), position);
}

assert(i == nCorners);

return FieldCell(lowerLeft, upperRight, std::move(neighbors));
}

Expand Down