Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linkage errors in BetheHeitlerApprox.hpp [backport #1777 to develop/v21.1.x] #1800

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

acts-project-service
Copy link
Collaborator

Backport a58b798 from #1777.

This should fix violations of ODR by either adding the inline keyword or by moving functions to a cpp file.

This should fix violations of ODR by either adding the `inline` keyword or by moving functions to a cpp file.

(cherry picked from commit a58b798)
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop/v21.1.x@e728d54). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             develop/v21.1.x    #1800   +/-   ##
==================================================
  Coverage                   ?   48.48%           
==================================================
  Files                      ?      385           
  Lines                      ?    21066           
  Branches                   ?     9702           
==================================================
  Hits                       ?    10213           
  Misses                     ?     4125           
  Partials                   ?     6728           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

📊 Physics performance monitoring for 9b1cae3

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Full report
Seeding: ❌ seeded, ❌ truth estimated, ❌ orthogonal
CKF: seeded, truth smeared, truth estimated, ❌ orthogonal
IVF: seeded, truth smeared, truth estimated, ❌ orthogonal
Ambiguity resolution: seeded, ❌ orthogonal
Truth tracking
❌ Truth tracking (GSF)

Vertexing ❌

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

❌ IVF orthogonal

Seeding ❌

❌ Seeding seeded

❌ Seeding truth_estimated

❌ Seeding orthogonal

CKF ❌

CKF seeded

CKF truth_smeared

CKF truth_estimated

❌ CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

🖼️ gsf_plots/pull_d0.pdf ❌🖼️ gsf_plots/res_d0.pdf ❌🖼️ gsf_plots/pull_qop.pdf ❌🖼️ gsf_plots/res_qop.pdf ❌

@paulgessinger
Copy link
Member

Failures are from intermediate fixes to the infra. I'm merging manually now.

@paulgessinger paulgessinger merged commit 12548a7 into develop/v21.1.x Jan 26, 2023
@paulgessinger paulgessinger deleted the backport-1777-to-develop/v21.1.x branch January 26, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants