Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve g4 sensitive surface mapper logging #1832

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 6, 2023

this way the user can (hopefully) understand why surfaces are not mapped correctly

@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 6, 2023
@andiwand andiwand added this to the next milestone Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1832 (0c47e00) into main (a20eebe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1832   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         407      407           
  Lines       22629    22629           
  Branches    10326    10326           
=======================================
  Hits        11210    11210           
  Misses       4230     4230           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

📊 Physics performance monitoring for 0c47e00

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit 6585f46 into acts-project:main Feb 8, 2023
@github-actions github-actions bot removed the automerge label Feb 8, 2023
@andiwand andiwand deleted the refactor-improve-g4-surface-mapper-logging branch February 14, 2023 10:03
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants