fix: G4 detector for Fatras sim

[andiwand]

Fatras did not see sensitive surfaces in a G4 detector because they were not wired correctly.

This PR adds a function on the core surface to allow attaching a detector element after construction which makes the surface sensitive. This also breaks the cyclic dependency in detector construction

[codecov]

Codecov Report

Merging #1887 (fc94972) into main (0d9f51b) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1887      +/-   ##
==========================================
- Coverage   49.45%   49.44%   -0.01%     
==========================================
  Files         408      408              
  Lines       22701    22704       +3     
  Branches    10370    10371       +1     
==========================================
  Hits        11226    11226              
- Misses       4263     4266       +3     
  Partials     7212     7212              

Impacted Files	Coverage Δ
Core/include/Acts/Surfaces/Surface.hpp	66.66% <ø> (ø)
Core/src/Surfaces/Surface.cpp	40.54% <40.00%> (-0.67%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[asalzburger]

Still some build failures it seems.

[github-actions]

📊 Physics performance monitoring for fc94972

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[andiwand]

fixed @asalzburger

[asalzburger]

Looks alright, let's go for it.