Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disambiguate seeds and prototracks in examples #1906

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Mar 1, 2023

seeds and prototracks are ambiguous in the examples framework. this PR tries to improve the situation by disentangling them

@andiwand andiwand changed the title refactor;disambiguate seeds and prototracks refactor: disambiguate seeds and prototracks in examples Mar 1, 2023
@andiwand andiwand added this to the next milestone Mar 1, 2023
@andiwand andiwand added Component - Examples Affects the Examples module 🚧 WIP Work-in-progress labels Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

📊 Physics performance monitoring for 864e7d9

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1906 (864e7d9) into main (a9278e3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1906   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         408      408           
  Lines       22704    22704           
  Branches    10363    10363           
=======================================
  Hits        11236    11236           
  Misses       4257     4257           
  Partials     7211     7211           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand andiwand requested a review from benjaminhuth March 3, 2023 09:09
@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Mar 3, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 3, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot merged commit 2d6f99d into acts-project:main Mar 3, 2023
@andiwand andiwand deleted the refactor/examples-disambiguate-seeds-and-prototracks branch March 3, 2023 19:37
@github-actions github-actions bot removed the automerge label Mar 3, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants