Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deleted track selector params in python #1907

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Mar 1, 2023

after #1874 some track selector params were not wired correctly

@andiwand andiwand added the Component - Examples Affects the Examples module label Mar 1, 2023
@andiwand andiwand added this to the next milestone Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1907 (9ec1529) into main (efa2ec6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1907   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         408      408           
  Lines       22704    22704           
  Branches    10371    10371           
=======================================
  Hits        11226    11226           
  Misses       4266     4266           
  Partials     7212     7212           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/BinnedSPGroup.hpp 0.00% <ø> (ø)
Core/include/Acts/Seeding/BinnedSPGroup.ipp 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

📊 Physics performance monitoring for 9ec1529

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@tboldagh tboldagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok Andreas. Thanks

@andiwand andiwand modified the milestone: next Mar 1, 2023
@kodiakhq kodiakhq bot merged commit 4e5f614 into acts-project:main Mar 1, 2023
@github-actions github-actions bot removed the automerge label Mar 1, 2023
@andiwand andiwand deleted the fix/remove-deleted-track-selector-params branch March 1, 2023 21:28
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants