refactor: Examples sequence elements gain Read/WriteDataHandles #1908
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1908 +/- ##
=======================================
Coverage 49.55% 49.55%
=======================================
Files 408 408
Lines 22695 22695
Branches 10356 10356
=======================================
Hits 11247 11247
Misses 4239 4239
Partials 7209 7209 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
benjaminhuth
added
Component - Examples
paulgessinger
force-pushed
the
refactor/fw-data-handles
branch
from
9dc0b33 to
0214b8b
Compare
|
This should be ready for review now, @benjaminhuth @andiwand |
paulgessinger
force-pushed
the
refactor/fw-data-handles
branch
from
6369276 to
71b6e44
Compare
Examples/Framework/include/ActsExamples/Framework/IAlgorithm.hpp
Outdated
Show resolved
Hide resolved
Examples/Framework/include/ActsExamples/Framework/WhiteBoard.hpp
Outdated
Show resolved
Hide resolved
Examples/Io/Root/include/ActsExamples/Io/Root/RootVertexPerformanceWriter.hpp
Show resolved
Hide resolved
📊 Physics performance monitoring for 4f731e9Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
Ok I think what this failure is telling is, that I can't make only the ODD sequence use the handles and have the Sequencer fail. So for this PR I'll downgrade the Sequencer ERROR to a warning, and won't throw. The data flow will still be correct, and the CI should tell us. I have a follow-up PR (almost) ready where I switch everything over and can reenable the ERROR and exception. |
|
Ok, I've added a config flag to the sequencer that defaults to False for the checking functionality. I'll default it to true with the other PR I was mentioning. Thoughts? |
|
sounds good to me 👍 |
Follow up to #1908. Switches over the rest of the Examples components. This also makes `WhiteBoard::{get,add}` private and adds the data handles as friends to restrict unregistered white board access.
This locks in the type at algorithm construction, registers the handles and allows checking the data flow more thoroughly before running the event sequence.
This PR only changes the components used in the ODD chain example, but we should probably extend this to the rest of the Examples components as well.
Blocked by: