Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GSF add final multi-component state to track container #1928

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Mar 8, 2023

This is triggered if the GSF finds the column "gsf-final-multi-component-state" in the track container. This does not yet include writing into a root file, since there is no TrackContainerWriter or something similar yet.

@benjaminhuth benjaminhuth added the 🚧 WIP Work-in-progress label Mar 8, 2023
@benjaminhuth benjaminhuth added this to the next milestone Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1928 (b4d3e9e) into main (6e35712) will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   49.82%   49.83%           
=======================================
  Files         421      421           
  Lines       23878    23900   +22     
  Branches    10835    10844    +9     
=======================================
+ Hits        11898    11910   +12     
- Misses       4366     4367    +1     
- Partials     7614     7623    +9     
Impacted Files Coverage Δ
Core/include/Acts/TrackFitting/GsfOptions.hpp 100.00% <ø> (ø)
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 41.78% <50.00%> (+0.35%) ⬆️
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 43.97% <60.00%> (+0.82%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

📊 Physics performance monitoring for b4d3e9e

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@benjaminhuth benjaminhuth marked this pull request as ready for review April 11, 2023 12:30
@benjaminhuth benjaminhuth added Component - Core Affects the Core module Feature Development to integrate a new feature and removed 🚧 WIP Work-in-progress labels Apr 11, 2023
@benjaminhuth benjaminhuth added the Component - Examples Affects the Examples module label Apr 11, 2023
@paulgessinger
Copy link
Member

Is this useful for debugging only, or also for primary outputs?

@benjaminhuth
Copy link
Member Author

Hmm so in principle this is not only for debugging, e.g. it could be useful in LDMX, but also I have some plans myself to try some things with this.

However, before that I will need to add a proper writer... But I would do this seperately, since I'm not yet sure how to approach this.

benjaminhuth and others added 2 commits April 12, 2023 13:53
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@kodiakhq kodiakhq bot merged commit 6db3613 into acts-project:main Apr 12, 2023
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
@benjaminhuth benjaminhuth deleted the feature/gsf-export-final-component-state branch May 10, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants