refactor: navigator interface #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started pulling the navigator into the actor/aborter calls so we can then call functions on it similar to the stepper I also aligned the parameter order of actor and aborter and improved some comments |
andiwand
force-pushed
the
refactor-navigator-interface
branch
from
0d1773e to
5ac908a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1931 +/- ##
=======================================
Coverage 49.59% 49.60%
=======================================
Files 410 410
Lines 22690 22693 +3
Branches 10356 10356
=======================================
+ Hits 11254 11257 +3
Misses 4224 4224
Partials 7212 7212
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 1fb2b2fFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
added
Component - Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started pulling the navigator into the actor/aborter calls so we can then call functions on it similar to the stepper