-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experimental navigator for experimental geometry #1932
feat: experimental navigator for experimental geometry #1932
Conversation
moved the code into this branch/PR @asalzburger @dimitra97 |
Codecov Report
@@ Coverage Diff @@
## main #1932 +/- ##
==========================================
+ Coverage 49.57% 49.59% +0.02%
==========================================
Files 412 413 +1
Lines 23310 23443 +133
Branches 10604 10666 +62
==========================================
+ Hits 11555 11627 +72
- Misses 4318 4336 +18
- Partials 7437 7480 +43
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for c67dc85Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently I forgot to press the submit button again 😄
here are my comments from yesterday
so I think two things are missing now: the start and the target surface. I think I will add it to stay compatible with the existing navigator and we will need it for the fitters anyway. the other thing would be to make the unit test actually assert on something IMO we could merge as is because it is just experimental and it will make prototyping for muons easier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this in & we can refine if needed in a follow-up.
@andiwand - ok, let's move this in, such that we can establish first testbeds, if we need refining/updating we will anyway learn this when using the new navigation interface. |
Great job, by the way! |
first draft of a navigator which can deal with the new geometry, navigation delegates and navigation state
I also added a small unit test that navigates through a box in a box
it also seemed to successfully find all the surfaces in a muon chamber mock up geometry