chore: rename unused params #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1952 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 411 411
Lines 23340 23340
Branches 10634 10634
=======================================
Hits 11557 11557
Misses 4332 4332
Partials 7451 7451
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 53b36e3Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
paulgessinger
approved these changes
Mar 16, 2023
Examples/Algorithms/Digitization/include/ActsExamples/Digitization/DigitizationConfig.hpp
Show resolved
Hide resolved
|
CI is green now. could you take another look @paulgessinger ? |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Mar 23, 2023
- rename `/*unused*/` params into something more understandable - improve doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/*unused*/params into something more understandable