-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: geant4 converters #2048
refactor: geant4 converters #2048
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
- Coverage 49.40% 49.39% -0.01%
==========================================
Files 434 434
Lines 24984 24984
Branches 11524 11526 +2
==========================================
- Hits 12343 12341 -2
Misses 4486 4486
- Partials 8155 8157 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 6c36307Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in principle ok with the PR, just wanted to cross-check on a few points.
Plugins/Geant4/include/Acts/Plugins/Geant4/Geant4Converters.hpp
Outdated
Show resolved
Hide resolved
Plugins/Geant4/include/Acts/Plugins/Geant4/Geant4Converters.hpp
Outdated
Show resolved
Hide resolved
Plugins/Geant4/include/Acts/Plugins/Geant4/Geant4Converters.hpp
Outdated
Show resolved
Hide resolved
@asalzburger implemented your suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, questions have been addressed.
split off changes from my calorimeter demo. this changes most of the shared pointers to unique pointers in the converter because we use unique pointers downstream sometimes. and unique pointers can be upgraded to shared pointers directly. it also includes a generalization of the material conversion and transform conversion
update and summary
unique_ptr
consistently toshared_ptr
after discussionGeant4VolumeConverter