-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for passing clusters to calibrator #2078
Conversation
b2bc3c8
to
5f2e76b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment: For me there is not real semantical advantage of an std::optional<std::reference_wrapper<const T>>
to a const T*
.
I think I would actually go for const T*
in such a case, because it is less verbose. But of course this is only my opinion, feel free to ignore it :)
Codecov Report
@@ Coverage Diff @@
## main #2078 +/- ##
=======================================
Coverage 49.31% 49.31%
=======================================
Files 427 427
Lines 24828 24828
Branches 11444 11444
=======================================
Hits 12245 12245
Misses 4514 4514
Partials 8069 8069 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for d8d4372Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
@benjaminhuth I think you're right -- I actually considered it but of course I couldn't miss an opportunity to over-engineer the thing! I'll update the PR. EDIT: now done, thanks. |
Currently, the measurement calibrators in TrackFittingAlgorithm do not have access to cluster-level information. One widely-used pattern in the real world is to apply different calibrations depending on the cluster dimensions for instance, so this information is useful. This PR adds an optional input to the TrackFittingAlgorithm which is handed down through the MeasurementCalibrator interface. The reference to the cluster collection is boxed in a
std::optional<std::reference_wrapper>
to simplify the interface.Ping @benjaminhuth for comments