Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing include and fix warning for GCC 13 #2079

Merged
merged 4 commits into from
May 2, 2023

Conversation

benjaminhuth
Copy link
Member

self explaining

@benjaminhuth benjaminhuth added the Component - Core Affects the Core module label May 2, 2023
@benjaminhuth benjaminhuth added this to the next milestone May 2, 2023
@benjaminhuth benjaminhuth requested a review from andiwand May 2, 2023 10:33
@benjaminhuth benjaminhuth changed the title fix: Add missing include for GCC 13 fix: Add missing include and fix warning for GCC 13 May 2, 2023
@paulgessinger paulgessinger linked an issue May 2, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2079 (b3cd327) into main (0d99a80) will not change coverage.
The diff coverage is n/a.

❗ Current head b3cd327 differs from pull request most recent head 55b26b9. Consider uploading reports for the commit 55b26b9 to get more accurate results

@@           Coverage Diff           @@
##             main    #2079   +/-   ##
=======================================
  Coverage   49.31%   49.31%           
=======================================
  Files         427      427           
  Lines       24808    24808           
  Branches    11436    11436           
=======================================
  Hits        12234    12234           
  Misses       4513     4513           
  Partials     8061     8061           
Impacted Files Coverage Δ
Core/include/Acts/EventData/TrackStatePropMask.hpp 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 2, 2023

📊 Physics performance monitoring for 55b26b9

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit 1f234e9 into acts-project:main May 2, 2023
@github-actions github-actions bot removed the automerge label May 2, 2023
@benjaminhuth benjaminhuth deleted the fix/gcc13-include branch May 10, 2023 07:15
@paulgessinger paulgessinger modified the milestones: next, v26.0.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACTS compilation failure with gcc13
3 participants