fix: Fix geometric digitization of generic detector #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Bug
📊 Physics performance monitoring for 82a5807Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #2081 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 439 439
Lines 25127 25127
Branches 11601 11601
=======================================
Hits 12436 12436
Misses 4438 4438
Partials 8253 8253 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@benjaminhuth is there any showstopper for this MR? I'd like to stop having to include my hotfix from #2020 in every build 😁 |
|
sorry, I'll finish it today! No showstoppers I think, unfortunately just forgot it. |
|
Awesome, thanks @benjaminhuth |
andiwand
reviewed
Jun 1, 2023
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds this to CI tests. Should be also tested for ODD, but maybe in a separate PR.
Fixes #2020