-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add full cov and pulls to VertexPerformanceWriter #2119
feat: Add full cov and pulls to VertexPerformanceWriter #2119
Conversation
📊 Physics performance monitoring for aae50be
Summary VertexingIVF seeded
IVF truth_smeared
IVF truth_estimated
IVF orthogonal
SeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #2119 +/- ##
=======================================
Coverage 49.45% 49.45%
=======================================
Files 434 434
Lines 25019 25019
Branches 11529 11529
=======================================
Hits 12373 12373
Misses 4494 4494
Partials 8152 8152 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This probably needs updates in the associated plotting script so it doesn't break physmon. |
Can we keep the FPE monitoring? Also seems unrelated to what the title says this PR does? |
the CI is crashing because of the FPE and I also face FPEs locally. It seems to highly depend on the rng at the moment and since we have no way of masking them and I have no time of chasing them all I dont see any other option |
This reverts commit fc3534d.
…om:andiwand/acts into feature-vtx-perf-writer-full-cov-and-pulls
This PR currently has a merge conflict. Please resolve this and then re-add the |
…perf-writer-full-cov-and-pulls
since people are looking more closely into vertex performance right now this might be helpful