refactor: move initialisation of vector in SeedFilter

[LuisFelipeCoelho]

This PR moves the initialisation of compatibleSeedR in seedFilter to reduce memory allocation

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@9cc6ef0). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2135   +/-   ##
=======================================
  Coverage        ?   49.43%           
=======================================
  Files           ?      434           
  Lines           ?    25003           
  Branches        ?    11523           
=======================================
  Hits            ?    12359           
  Misses          ?     4490           
  Partials        ?     8154           

Impacted Files	Coverage Δ
Core/include/Acts/Seeding/SeedFilter.ipp	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for dd73884

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[andiwand]

did you reach a conclusion on this one @LuisFelipeCoelho @CarloVarni ?

[CarloVarni]

@LuisFelipeCoelho @andiwand I'm ok with this PR, but I cannot resolve the discussion... looks like github is not allowing the one opening the discussion to close it ...